Repository navigation
fix(paths): delete the dead tmpdir bypass entry, and pin what the list is - #111
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…t is `getDefaultAllowedDirs` carries a test-mode bypass for directories that may be absent on a CI runner, and `os.tmpdir()` was one of its entries. A bypass only spares a directory the existence filter would drop, so it cannot add one that was never a candidate. `os.tmpdir()` was not a candidate: it was never in the allow-list on any machine, while reading as always-allowed. I tried the other fix first, pushing it onto the candidate list so the bypass earned its entry. That makes every `mkdtemp` fixture legal without a `customAllowed` widening, and it is what the comment always claimed. It also breaks four suites that used `os.tmpdir()` as the thing outside the whitelist, because it stops being outside: `security_suite`'s blocked dir, `adversarial-tool-gates`' outside dir, a hardcoded `/tmp/...` in `v5-regressions`, and `once-single-pass`' "exits 1 when a directory is refused by the path gate". The only portable replacement is a fresh dir directly in the home directory, which is what AGENTS.md rule 1 refuses. A test-mode allow-list is the last thing to widen casually. So the dead entry is gone and the comment states what a bypass can and cannot do. Nothing about the allow-list changes. The new suite pins the result: cwd is there, the bypassed home dirs are there even when absent, the temp directory is not, a non-bypassed missing dir is still dropped, and no directory is listed twice. Mutation-checked by making `os.tmpdir()` a real candidate; the pin goes red. Commit made by Step 5 Preview Free in OpenCode on behalf of Kriday.
kridaydave
force-pushed
the
k5/debt-tmpdir-bypass
branch
from
October 13, 2026 16:58
e47582c to
3657c2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes stale tmpdir bypass entry and pins allowed list. Adds default-allowed test coverage.