feat: persist active tab in TabList via URL search param#72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TabListnow persists the active tab in the URL as a search parameter (tab-<uid>)replace(notpush) to avoid polluting browser historywidgetEndpoint) are preserved when a tab changesImplementation
The change is contained entirely in
src/widgets/TabList/TabList.tsx:useSearchParamsreads and writes the active tab keytab-<uid>) so multiple TabLists on the same page don't collideBehaviour across navigation scenarios
replace) ✓pathnavigate to a page containing a TabListresourceRefIdnavigate on the same page?widgetEndpoint=<encoded>— tab param stripped, but TabList is not rendered in this state ✓tab-<uid>param — no collisions ✓Test plan
navigateaction from a widget on the same page — confirm tab param does not interfere🤖 Generated with Claude Code