Repository navigation
fix: focus firefox popup issue - #123
Merged
Merged
Conversation
added 3 commits
August 25, 2026 09:52
added 8 commits
August 25, 2026 10:54
jtanya17
reviewed
Aug 26, 2026
jtanya17
reviewed
Aug 26, 2026
| "@commitlint/cli": "^16.2.1", | ||
| "@commitlint/config-conventional": "^16.2.1", | ||
| "@krakenjs/grumbler-scripts": "^8.0.4", | ||
| "babel-plugin-transform-es2015-modules-commonjs": "6.26.2", |
Contributor
There was a problem hiding this comment.
Is this needed for the flow-type change?
Contributor
Author
There was a problem hiding this comment.
Seems like we need this — I tried reverting and pushing, but the npm run build step is failing in CI
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 73.31% 73.13% -0.19%
==========================================
Files 26 26
Lines 952 953 +1
==========================================
- Hits 698 697 -1
- Misses 254 256 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nikrom17
reviewed
Aug 26, 2026
| }).then(({ isPopup, name }) => { | ||
| if (isPopup && name) { | ||
| window.open("", name, "noopener"); | ||
| const win = this.getWindow(); |
Member
There was a problem hiding this comment.
Can we add a simple test for this so we can get a green lcov report?
jtanya17
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user initiates the PayPal checkout popup, switches to a different browser tab, and then clicks "Click to Continue" on the original tab, Firefox opens a new empty tab.
[LI-190132]
Steps to Reproduce
Open PayPal checkout popup
Switch to a different browser tab
Return to original tab and click "Click to Continue"
blank tab opens in Firefox
Testing
Local setup:
Clone/build Krakenjs/post-robot repo and symlink it into smartcomponentnodeweb and clientsdknodeweb:
Start both scnw and csnw servers pointing to local.