Migrate setup-go-kpt action reference to kpt repo - #1164
Merged
Conversation
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
It should be merged only after the merge of kptdev/krm-functions-sdk#768 and kptdev/krm-functions-catalog#1295 |
|
aravindtga
marked this pull request as ready for review
September 1, 2026 08:29
aravindtga
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
September 1, 2026 08:29
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s GitHub Actions workflows to use the setup-go-kpt composite action from the upstream kptdev/kpt repository, removing the previously vendored local action.
Changes:
- Updated workflow steps to use
kptdev/kpt/.github/actions/setup-go-kpt@maininstead of./.github/actions/setup-go-kpt. - Removed the now-unused local composite action definition at
.github/actions/setup-go-kpt/action.yml. - (Related finding) One workflow still references an invalid
actions/checkout@v7.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/sonar-ci-artifacts.yaml | Switch setup-go-kpt action reference to upstream repo. |
| .github/workflows/release.yaml | Switch setup-go-kpt action reference to upstream repo. |
| .github/workflows/porchctl-dev-release.yaml | Switch setup-go-kpt action reference to upstream repo. |
| .github/workflows/porch-e2e-nightly.yaml | Switch setup-go-kpt action reference to upstream repo (2 jobs). |
| .github/workflows/porch-e2e-ci-jobs.yaml | Switch setup-go-kpt action reference to upstream repo (2 jobs). |
| .github/workflows/image-build-push-release.yaml | Switch setup-go-kpt action reference to upstream repo. |
| .github/workflows/gosec-scan.yaml | Switch setup-go-kpt action reference to upstream repo. |
| .github/workflows/golangci-lint.yaml | Switch setup-go-kpt action reference to upstream repo. |
| .github/actions/setup-go-kpt/action.yml | Delete local composite action now replaced by upstream reference. |
Suppressed comments (2)
.github/workflows/porch-e2e-nightly.yaml:120
- Using
@mainfor a third-party action makes the workflow non-reproducible and increases supply-chain risk; pin to a specific commit SHA (or a version tag) instead.
uses: kptdev/kpt/.github/actions/setup-go-kpt@main
.github/workflows/porch-e2e-ci-jobs.yaml:148
- Using
@mainfor a third-party action makes the workflow non-reproducible and increases supply-chain risk; pin to a specific commit SHA (or a version tag) instead.
uses: kptdev/kpt/.github/actions/setup-go-kpt@main
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mozesl-nokia
approved these changes
Sep 1, 2026
efiacor
approved these changes
Sep 1, 2026
rendre-greyling
pushed a commit
to nokia/kpt-porch
that referenced
this pull request
Sep 7, 2026
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
setup-go-kptaction references from local./.github/actions/setup-go-kpttokptdev/kpt/.github/actions/setup-go-kpt@main, and removed the now-unused local action directory.github/actions/setup-go-kpt/Type of Change
Checklist
AI Disclosure
If so, please describe how:
- Kiro to update the workflow references and prepare the PR.