Feat: implement font display and update with skin updates - #11
Conversation
|
Warning Review limit reached
Next review available in: 54 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR adds remote font-family support to ChangesFont theme support and example integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@example/lib/pages/home_page.dart`:
- Around line 210-228: Raise the Flutter SDK lower bound in pubspec.yaml above
the version that introduced ColorScheme.tertiaryContainer and
onTertiaryContainer, keeping the constraint consistent with the roles used by
the Close button in the surrounding widget.
In `@lib/models/skin_model.dart`:
- Line 29: Remove the unconditional full-map print from SkinModel.fromMap in
lib/models/skin_model.dart, replacing it with controlled redacted diagnostics
only if needed; also remove or debug-gate the per-tap color print in
example/lib/pages/home_page.dart lines 211-213.
In `@lib/remote/fskin_remote_config.dart`:
- Around line 74-78: Update the ThemeData emitted by the skin change stream in
FlutterSkin.onSkinChanged to include the cached configuration’s fontFamily
alongside colorScheme, matching FlutterSkin.toThemeData(). Add or update a
stream test to verify emitted ThemeData.fontFamily reflects remote font changes.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: cdde5cb6-83b5-4daf-9b69-3ecc7e25b8bd
⛔ Files ignored due to path filters (2)
example/assets/fonts/opensans.ttfis excluded by!**/*.ttfexample/assets/fonts/robotomono.ttfis excluded by!**/*.ttf
📒 Files selected for processing (6)
example/lib/main.dartexample/lib/pages/home_page.dartexample/pubspec.yamllib/flutter_skin.dartlib/models/skin_model.dartlib/remote/fskin_remote_config.dart
| onPressed: () { | ||
| print( | ||
| 'onTertiaryContainer: ${Theme.of(context).colorScheme.onTertiaryContainer}', | ||
| ); | ||
| Navigator.pop(context); | ||
| }, | ||
| child: Container( | ||
| padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8), | ||
| decoration: BoxDecoration( | ||
| color: Theme.of(context).colorScheme.tertiaryContainer, | ||
| borderRadius: BorderRadius.circular(4), | ||
| ), | ||
| child: Text( | ||
| 'Close', | ||
| style: TextStyle( | ||
| color: Theme.of(context).colorScheme.onTertiaryContainer, | ||
| ), | ||
| ), | ||
| ), |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n -C 2 \
'environment:|sdk:|flutter:|flutter-version|channel:' \
--glob 'pubspec.yaml' \
--glob 'pubspec.lock' \
--glob '.fvmrc' \
--glob 'fvm_config.json' \
--glob '*.yml' \
--glob '*.yaml' \
. || trueRepository: koukibadr/flutter_skin
Length of output: 2047
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'Repository SDK declarations:\n'
rg -n 'environment:|sdk:|flutter:|packageInfo|flutter_version|minimum_supported|requires_flutter|pubspec' \
--glob 'pubspec.yaml' --glob 'README.md' --glob '.github/**' --glob 'analysis_options.yaml' . || true
printf '\nRelevant home_page.dart section:\n'
wc -l example/lib/pages/home_page.dart
sed -n '180,245p' example/lib/pages/home_page.dart
printf '\nFind ColorScheme.tertiaryContainer usages:\n'
rg -n 'onTertiaryContainer|tertiaryContainer' . || trueRepository: koukibadr/flutter_skin
Length of output: 3019
Keep the Flutter lower bound consistent with the new color roles.
tertiaryContainer and onTertiaryContainer require a Flutter version newer than >=1.17.0, but pubspec.yaml still declares that lower bound and allows clients to run with an unsupported SDK. Raise the flutter constraint above the version that introduced these ColorScheme roles.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@example/lib/pages/home_page.dart` around lines 210 - 228, Raise the Flutter
SDK lower bound in pubspec.yaml above the version that introduced
ColorScheme.tertiaryContainer and onTertiaryContainer, keeping the constraint
consistent with the roles used by the Close button in the surrounding widget.
Source: MCP tools
1 participant
Summary by CodeRabbit
New Features
Style