Repository navigation
v2.12.3 — search that finishes the thought - #70
Merged
Merged
Conversation
…ery, absolute date on the edited stamp (v2.12.3) A small QoL wave on top of the interactive-graph merge, nothing broken: 336 headless tests green, clippy clean. - No-results search now offers "Создать страницу \u201c<query>\u201d" (click or Enter) — the page is created with the typed title via the same create_page_titled path wiki-links use, the search clears, and the caret lands in the new page's subject (focus flag consumed by the document view). - Esc with the field focused empties the query; the next Esc reaches the global handlers. Two egui lessons encoded in comments: a singleline TextEdit surrenders focus while still processing the Escape, so the field's focus is remembered from the previous frame in temp memory; and the stored flag is read before taking the context write lock, because Response methods share that RwLock (nesting them deadlocked, caught by the test as 'Failed to acquire RwLock write after 10s'). - The 'edited Nm ago' stamp shows the absolute local timestamp (dd.mm.yyyy hh:mm) on hover; formatting is extracted to NativeApp::edited_absolute_stamp with a format test. - Enter over a non-empty result list opens the top result through the same frame-start focus probe — the old mid-frame probe observed the field as already blurred on the Enter frame and dropped the keystroke. New tests: enter_in_empty_search_requests_page_creation, escape_clears_a_focused_search_without_creating, edited_stamp_format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report
QoL wave on top of the interactive-graph merge (PR #69). Rule of the wave: break nothing — 336 headless tests green, clippy clean.
Added
create_page_titledpath wiki-links use; the search clears and the caret lands in the new page's subject.Changed
dd.mm.yyyy hh:mm).Notable egui lessons (encoded in comments)
memory.focused()is already empty when widgets draw; the field's focus is remembered from the previous frame.response.has_focus()inside adata_mutclosure deadlocks (the test caught it: «Failed to acquire RwLock write after 10s»).Tests
336 passed: new
enter_in_empty_search_requests_page_creation,escape_clears_a_focused_search_without_creating,edited_stamp_format.Type