Repository navigation
fix: restore em dash in CLI help header - #24
Merged
Merged
Conversation
The em dash in the --help header was double-encoded (UTF-8 bytes E2 80 94 read as CP437 and re-encoded), so every user running shipkit --help saw a mojibake sequence in the first line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The em dash in the
shipkit --helpheader was double-encoded: the correctUTF-8 bytes
E2 80 94had been decoded as CP437 and re-encoded as UTF-8,producing
CE 93 C3 87 C3 B6.Every user running
shipkit --helpsaw the mojibake sequence in the first lineof output.
Type of change
Verification
Byte check on
lib/cli.mjsline 18:CE 93 C3 87 C3 B6E2 80 94node bin/shipkit.mjs --helpnow prints:npm test— 8/8 passingChecklist
npm testpasses locallylib/*.test.mjsfor behavior changesRelease impact
None. The change affects only the help text string.