-
-
Notifications
You must be signed in to change notification settings - Fork 24
feat(storage): discover / sync / reconcile / CLI (PR2 of 4) #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sidd-27
wants to merge
11
commits into
kornia:feat/bubbaloop-storage-spec
Choose a base branch
from
sidd-27:storage-pr2-sync-cli
base: feat/bubbaloop-storage-spec
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f05cf30
feat(storage): add storage foundation module (PR1)
ddabd72
chore: add osx-arm64 platform to pixi workspace
53511ec
feat(storage): add reconcile diff-matrix healing primitive (PR2)
030f001
feat(storage): add sync upload core — backoff, dead-letter, upload se…
c4899c3
feat(storage): add `bubbaloop storage` CLI + config/backend factory (…
c791f59
fix(storage): address code-review findings (security, correctness, ef…
40403d0
feat(storage): add `storage profile` CLI verbs (PR2)
538e069
feat(storage): add `storage configure` CLI + config writer (PR2)
0b27545
feat(storage): add storage::discover + `storage topics` CLI (PR2)
690487c
feat(storage): add S3-compatible backend behind `s3` feature (PR2)
78d4645
docs(storage): update storage CLI module doc for the full PR2 verb su…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed ? I would focus on local now. No cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec that you shared for the storage system does mention that the backend uses local FS default and S3 compact as a flag. So I just decided to go with what the spec says
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets simplify