feat: Add Message tab and bulk message sending to Commander plugin#39
feat: Add Message tab and bulk message sending to Commander plugin#39linonetwo wants to merge 1 commit intokookma:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new "Message" tab to the Commander plugin that enables bulk message sending to selected tiddlers. The feature addresses issue #38 by providing a UI for users to send custom TiddlyWiki messages to multiple tiddlers at once, with support for optional custom named parameters using TiddlyWiki's ActionSendMessageWidget $names/$values attributes.
Changes:
- Added new "Message" tab with UI for sending bulk messages to selected tiddlers
- Implemented support for custom named parameters via $names and $values filter expressions
- Added operation logging consistent with other Commander operations
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| source/commander/message/ui.tid | Main UI tab that integrates Message functionality into Commander plugin |
| source/commander/message/uicomp/send-message.tid | UI component with form inputs for message name and optional custom parameters |
| source/commander/message/macros/send.tid | Macro that implements bulk message sending logic with logging |
| test-wiki/plugins/commander/message/ui.tid | Test wiki copy of main UI tab |
| test-wiki/plugins/commander/message/uicomp/send-message.tid | Test wiki copy of UI component |
| test-wiki/plugins/commander/message/macros/send.tid | Test wiki copy of macro implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| tag="input" | ||
| default="" | ||
| class="cmd-txt-area2" | ||
| placeholder=" e.g. navigateTo targetTiddler"/> |
There was a problem hiding this comment.
The placeholder "e.g. navigateTo targetTiddler" does not match the expected filter expression format described in the help text below. For better user experience, the placeholder should demonstrate valid filter syntax such as "[[navigateTo]] [[targetTiddler]]" or just "[[navigateTo]]" to align with the instruction that says "Filter expression for names; e.g. [[navigateTo]]".
| placeholder=" e.g. navigateTo targetTiddler"/> | |
| placeholder=" e.g. [[navigateTo]] [[targetTiddler]]"/> |
| tag="input" | ||
| default="" | ||
| class="cmd-txt-area2" | ||
| placeholder=" e.g. MyNote <<currentTiddler>>"/> |
There was a problem hiding this comment.
The placeholder "e.g. MyNote <>" does not demonstrate valid filter expression syntax. The help text below correctly indicates to use [<currentTiddler>], but the placeholder shows macro syntax instead. For consistency and to prevent user confusion, the placeholder should use valid filter syntax, such as "[]" or "[[MyNote]] []".
| placeholder=" e.g. MyNote <<currentTiddler>>"/> | |
| placeholder=" e.g. [[MyNote]] [<currentTiddler>]"/> |
| tag="input" | ||
| default="" | ||
| class="cmd-txt-area2" | ||
| placeholder=" e.g. navigateTo targetTiddler"/> |
There was a problem hiding this comment.
The placeholder "e.g. navigateTo targetTiddler" does not match the expected filter expression format described in the help text below. For better user experience, the placeholder should demonstrate valid filter syntax such as "[[navigateTo]] [[targetTiddler]]" or just "[[navigateTo]]" to align with the instruction that says "Filter expression for names; e.g. [[navigateTo]]".
| placeholder=" e.g. navigateTo targetTiddler"/> | |
| placeholder=" e.g. [[navigateTo]] [[targetTiddler]]"/> |
| tag="input" | ||
| default="" | ||
| class="cmd-txt-area2" | ||
| placeholder=" e.g. MyNote <<currentTiddler>>"/> |
There was a problem hiding this comment.
The placeholder "e.g. MyNote <>" does not demonstrate valid filter expression syntax. The help text below correctly indicates to use [<currentTiddler>], but the placeholder shows macro syntax instead. For consistency and to prevent user confusion, the placeholder should use valid filter syntax, such as "[]" or "[[MyNote]] []".
| placeholder=" e.g. MyNote <<currentTiddler>>"/> | |
| placeholder=" e.g. [[MyNote]] [<currentTiddler>]"/> |
Not sure why you need to copy paste things to test-wiki
closes #38