injection opa result as header, local integrasion test pass - #1
Open
leeofri wants to merge 4 commits into
Open
Conversation
Eyal-Shalev
reviewed
Jun 20, 2021
Comment on lines
+57
to
+65
| -- it("allow access return baggae in header - default key ", function() | ||
| -- _G.ngx.var.upstream_uri = "/api/endpoint/baggage" | ||
| -- local res = access.execute(conf) | ||
| -- print("lee -spec res") | ||
| -- print(res) | ||
| -- -- assert.request(res).has.header("baggage") | ||
| -- -- assert.is_true(res.headers["baggage"] == "BASE64_JWT_INTERNAL") | ||
| -- end) | ||
|
|
Eyal-Shalev
reviewed
Jun 20, 2021
|
|
||
| -- access allowed | ||
| kong.log.debug(interp("Access allowed to ${method} ${path} for user ${subject}", { | ||
| kong.log.debug(interp("Access 2 allowed to ${method} ${path} for user ${subject}", { |
Eyal-Shalev
reviewed
Jun 20, 2021
| if type(res.result) == "table" then | ||
| local baggage_key = conf.policy.baggage_key_in_result | ||
| if res.result[baggage_key] ~= nil then | ||
| inject_header(baggage_key,res.result.baggage) |
There was a problem hiding this comment.
bug
Suggested change
| inject_header(baggage_key,res.result.baggage) | |
| inject_header(baggage_key, res.result[baggage_key]) |
Eyal-Shalev
reviewed
Jun 20, 2021
| if res.result[baggage_key] ~= nil then | ||
| inject_header(baggage_key,res.result.baggage) | ||
| kong.log.debug(interp("Baggage header injected ${baggage}", { | ||
| baggage = res.result.baggage |
Eyal-Shalev
previously approved these changes
Jun 20, 2021
Eyal-Shalev
approved these changes
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.