Include location bias into rescoring#1051
Conversation
|
I'm seeing a couple of unexpected results. Searching for |
a5ef60d to
f89fd7f
Compare
Also moves the debug output after the raw_data output.
Reverse doesn't need sorting, so don't waste time on it.
This will allow for reuse later. Also changes the formula slightly.
This allows moving the weight for the score functions out of the QueryBuilder.
90a1328 to
5949947
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 5949947. Configure here.
Favours results closer to the center point.
5949947 to
b5fb6ee
Compare
|
Added a couple of adjustments to balance out the various use-cases:
I've also adjusted the focus radius computation some more. The result seems to be fairly decent for the planet test set. We might do something with getting more result candidates and doing some post-filtering in order to get result list that don't have obvious outliers down the list but that is something for the next version. |
geocoder-acceptance-tests are now green with that branch merged. ref * https://github.com/komoot/photon/releases/tag/1.1.0 * komoot/photon#1051

This extends the rescoring algorithm from #1041 to also take into account the score from the location bias. Thus the final OpenSearch score is now neatly split into match score, importance score and location bias score. The location bias score is added such that if nothing suitable is found in the focus area, the rescoring behaves exactly as if no location bias was set at all.
This also changes the size of the focus area (larger for large zooms, smaller for smaller ones) and the default zoom (14 -> 12) and location_bias_score (0.2 -> 0.4).
The PR also adds the output of OpenSearch's explain to the debug output for search. That can be useful to understand how the score came to be.
@henrik242 would you mind checking the effects on your data?
Closes #1024.