fix: make mobile navbar search bar compact#837
Open
chethanamp22-tech wants to merge 1 commit into
Open
Conversation
|
@chethanamp22-tech is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary [required]
The mobile navbar menu existed in HTML and CSS but was non-functional because the initMobileNav() function in the JS file was incomplete — it located the toggle and menu elements but never attached any event listeners. This PR completes the function and also fixes the mobile search bar which was oversized due to shared CSS rules between desktop and mobile inputs.
Related Issue [required]
Closes #835
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
How to Test This PR [required]
Expected test output:
Test Results [required]
Pre-existing test failure on main branch unrelated to this PR:
ImportError: cannot import name 'WEIGHT_LEVEL' from 'utils.recommender'
This PR only modifies static/style.css, static/script.js and index.html.
No Python files were touched.
Screenshots (if UI change)
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
The initMobileNav() function was stubbed out but never completed. No new dependencies or logic changes outside the navbar scope.