feat(learning-path): add server-side API with token-based ownership verification#830
Open
nancysangani wants to merge 1 commit into
Open
Conversation
|
@nancysangani is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @komalharshita, please review the PR when you get a chance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a server-side
/api/learning-path/<path_id>endpoint (POST / GET / PUT)with ownership verification baked in from the start. Each learning path is
bound to an owner token at creation time. Every subsequent read or write must
present that same token — requests with a missing or wrong token receive
403 Forbiddenbefore any data is read or modified. Token comparisons usesecrets.compare_digest(constant-time) to prevent timing-based enumeration.Related Issue
Closes #736
Type of Change
What Was Changed
utils/learning_path.pyPathNotFoundError/PathAlreadyExistsError/AuthorizationErrorhierarchy,_clear_all()test helperroutes/main_routes.pyPOST(create),GET(read),PUT(update); all enforce token ownership before touching datatests/test_learning_path.pyHow to Test This PR
git checkout fix/learning-path-authorizationpip install -r requirements.txtpython tests/test_learning_path.pyTest Results
40 passed, 0 failed out of 40 tests
Self-Review Checklist
fix/)python tests/test_learning_path.py→ 40 passed, 0 failedmain_routes.pyare unchanged frommain)print()orconsole.log()debug statements