fix: hoist window.addSkill and remove duplicate broken submit listener#823
Open
nancysangani wants to merge 1 commit into
Open
fix: hoist window.addSkill and remove duplicate broken submit listener#823nancysangani wants to merge 1 commit into
nancysangani wants to merge 1 commit into
Conversation
|
@nancysangani is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @komalharshita, please review the PR when you get a chance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #810
Three bugs in
initIndexPage()inscript.jscaused all skill interactions to silently fail.Root causes:
skillsTextInputreferenced but never declared — threwReferenceErrorwhen form was submitted, preventing recommendations from generatingwindow.addSkilldefined inside the first submit handler instead of atinitIndexPage()scope — chip click handlers and the Enter key handler found itundefinedbefore any form submission occurredform.addEventListener("submit")binding — the broken first listener was never removed when the correct second one was addedChanges:
static/script.js— hoistedwindow.addSkillto top ofinitIndexPage()scope; removed the entire broken first submit listener; no changes to the correct second submit listenertests/test_skills_input.py— 35 tests covering DOM landmark presence, chipdata-skillattributes,skillsTextInputabsence,window.addSkillhoisting, single submit listener, Enter key wiring, and API payload contract