fix: replace hardcoded progress cap with derived PROGRESS_MAX_POINTS#807
Open
nancysangani wants to merge 1 commit into
Open
fix: replace hardcoded progress cap with derived PROGRESS_MAX_POINTS#807nancysangani wants to merge 1 commit into
nancysangani wants to merge 1 commit into
Conversation
|
@nancysangani is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @komalharshita, please review the PR when you get a chance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #738
computeProgressPointsused a hardcoded divisor of250that was lower than what a normal user accumulates, producing percentages above 100% before theMath.minclamp. The clamp fixed the display but leftaria-valuenowset to values like150, violating the ARIA progressbar spec.Changes:
static/script.js— extracted per-action point values and activity targets as named constants;PROGRESS_MAX_POINTS(450) is derived from those constants;computeProgressPointsclampsprogress.pointsat max; percentage formula usesPROGRESS_MAX_POINTSas divisortests/test_progress_calculation.py— 28 tests: arithmetic correctness, original bug scenario regression, clamp behaviour, ARIA attribute validation, accessibility range checks