Replace forward references with header file#286
Open
alvgaona wants to merge 2 commits intokoide3:masterfrom
Open
Replace forward references with header file#286alvgaona wants to merge 2 commits intokoide3:masterfrom
alvgaona wants to merge 2 commits intokoide3:masterfrom
Conversation
Forward references for GSTAM are aliases rather than classes. Defining them as forward reference clases require unnecessary processing. Better to use header files.
- Replace forward declarations with actual includes in callbacks.hpp, sub_mapping.hpp, data_validator.hpp, and interactive_viewer.hpp - Add proper GTSAM includes instead of relying on forward declarations - Fix smart pointer dereference in odometry logging - Improve type safety in convert_to_string with size_t and vector<bool> specialization
alvgaona
force-pushed
the
fix/forward-references
branch
from
2a37411 to
121e5bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.