Fix pack and prerelease workflow #145
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issues with the NuGet pack operation and prerelease workflow configuration. The changes update how the generator DLL is included in the NuGet package, remove a prerelease flag from the release workflow, and bump the prerelease package version.
Changes:
- Modified the pack configuration to reference the Generator DLL from its bin directory instead of the output path
- Removed the
include-prerelease: Trueflag from the .NET setup in the release workflow - Bumped the prerelease package version from 4.0.0 to 5.0.0
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/EntityFrameworkCore.Projectables.Abstractions/EntityFrameworkCore.Projectables.Abstractions.csproj | Changes the DLL inclusion path from $(OutputPath) to an explicit relative path to fix pack operation |
| .github/workflows/release.yml | Removes include-prerelease flag from .NET 10.0.x setup |
| .github/workflows/build.yml | Bumps prerelease version from 4.0.0-pre to 5.0.0-pre |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <ItemGroup> | ||
| <!-- Package the generator in the analyzer directory of the nuget package --> | ||
| <None Include="$(OutputPath)\EntityFrameworkCore.Projectables.Generator.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> | ||
| <None Include="..\EntityFrameworkCore.Projectables.Generator\bin\$(Configuration)\netstandard2.0\EntityFrameworkCore.Projectables.Generator.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> |
There was a problem hiding this comment.
The change from using $(OutputPath) to an explicit relative path may introduce build order dependencies. The pack operation will now fail if the EntityFrameworkCore.Projectables.Generator project has not been built first in the correct configuration. While this approach can work, it relies on MSBuild building projects in the correct order. Consider verifying that the solution build order ensures the Generator project is built before this project is packed. Alternatively, you could use a build target that explicitly depends on the Generator project's build output to ensure proper sequencing.
|
@koenbeuk after merging this, I tried to publish a v5.0.1 with the same changelog as v5.0.0 plus a not about the fact that it's the same as v5.0.1, but got a nuget api key issue (everything work except this), see I may need your help to make the release |
No description provided.