fix: when sorting by track, disc number is not considered#117
Open
melopepo wants to merge 1 commit intokoel:masterfrom
Open
fix: when sorting by track, disc number is not considered#117melopepo wants to merge 1 commit intokoel:masterfrom
melopepo wants to merge 1 commit intokoel:masterfrom
Conversation
When sorting songs by "track", we currently ignore the disc number. This means if there's an album with multiple discs, it will be sorted as: ``` disc1 track1 disc2 track1 disc1 track2 disc2 track2 disc1 track3 disc2 track3 ``` Instead it makes more sense to sort as: ``` disc1 track1 disc1 track2 disc1 track3 disc2 track1 disc2 track2 disc2 track3 ``` The proposed change adds the disc number before the track number (and also prefix track numbers with zeros to ensure alphabetical order is consistent with numerical order)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sorting songs by "track", we currently ignore the disc number. This means if there's an album with multiple discs, it will be sorted as:
Instead it makes more sense to sort as:
The proposed change adds the disc number before the track number (and also prefix track numbers with zeros to ensure alphabetical order is consistent with numerical order)
I haven't been able to setup the project to build locally, so this needs a test still.
Thanks for making this great project!