-
Notifications
You must be signed in to change notification settings - Fork 3
KOB-51832 Removed pages and made redirects #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughDocumentation navigation links for Figma integration and validation features are removed from navigation files while corresponding page aliases are added to index files across integrations, session-explorer, and test-management modules. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
docs/modules/integrations/nav.adoc(0 hunks)docs/modules/integrations/pages/index.adoc(1 hunks)docs/modules/session-explorer/nav.adoc(0 hunks)docs/modules/session-explorer/pages/validations/validate-accessibility.adoc(1 hunks)docs/modules/test-management/nav.adoc(0 hunks)docs/modules/test-management/pages/index.adoc(1 hunks)
💤 Files with no reviewable changes (3)
- docs/modules/integrations/nav.adoc
- docs/modules/test-management/nav.adoc
- docs/modules/session-explorer/nav.adoc
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-16T07:27:41.117Z
Learnt from: tungmhoang
Repo: kobiton/docs PR: 395
File: docs/modules/integrations/pages/uipath/mobile-test-uipath.adoc:11-15
Timestamp: 2025-12-16T07:27:41.117Z
Learning: For all documentation files under docs/modules/integrations/pages/ (and its subdirectories) that reference platform version requirements for device support, use 'Kobiton' as the product name (not 'Portal') and express versions without the trailing 'S'. Example: 'Kobiton 4.19.6 and above' instead of 'Portal 4.19.6S and above'.
Applied to files:
docs/modules/integrations/pages/index.adoc
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: publish-docs-test
- GitHub Check: Test Build
🔇 Additional comments (2)
docs/modules/session-explorer/pages/validations/validate-accessibility.adoc (1)
80-81: Verify that aliased pages are properly unpublished and alias paths are correctly scoped.The page-alias addition correctly follows Antora syntax, but several aspects require verification to ensure the redirect strategy works as intended:
- Alias target verification: Confirm that
validate-ui-design.adocis being unpublished (underscore convention) in this PR rather than deleted, ensuring users landing on old links receive a proper redirect.- Path scope: Verify that the relative path
validate-ui-design.adoccorrectly resolves within the samevalidations/directory in Antora's routing system.- Cross-module consistency: Note that
validate-ui-design.adocis also aliased inintegrations/pages/index.adoc—confirm this dual-alias structure is intentional and won't cause routing conflicts.docs/modules/test-management/pages/index.adoc (1)
10-12: Verify that all unpublished validation pages are correctly referenced in the alias list.The page-aliases directive uses correct Antora syntax and appropriately consolidates multiple validation pages into a single redirect target. However, confirm the following:
- Completeness: Verify that the four aliased validation pages (
validation/index.adoc,validation/color-text-validation.adoc,validation/performance-validation.adoc,validation/text-validation.adoc) represent all validation pages being unpublished from the test-management module.- Path resolution: Confirm that relative paths with the
validation/prefix correctly resolve within the test-management module structure in Antora.- Navigation synchronization: Ensure the removed validation subsection links in
test-management/nav.adoc(mentioned in the AI summary) align exactly with these aliased pages.
Summary
Unpublished the Figma integration docs (entire directory) and Validations using Antora’s underscore convention and added redirects to the Integrations index. Content is preserved in git and can be restored easily if needed. Removed and redirected Validate UI design page which mentioned Figma.
Related PRs, issues, or features (optional)
Metadata
PR contributor checklist
[✅ ] My PR follows the Kobiton Docs contributor guidelines, meaning:
nav.adocfile.en-us) from my URLs.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.