Repository navigation
fix(corpus): spread the replicate runs so a seconds clock reads as fresh - #4
Merged
Merged
Conversation
The leakage corpus ran its three replicate runs first and back to back. A KeyPackage's createdAt, notBefore and expiresAt are whole seconds (mls_adapter: now_seconds * 1000), so when those three runs fell inside one second and a later run did not, the fields held still across the replicates yet differed elsewhere, and the classifier read them as carrying every secret. only_a_payloads_size_reaches_the_host then failed on main after #3, though the same code had passed on the PR. The replicates now sit at the first run, the last and one in the middle. Runs execute in order, so a value read off a coarse clock either differs between the two ends and is fresh, or is the same in every run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI on
mainfailed after #3 inleakage_corpus::only_a_payloads_size_reaches_the_host, though the same code passed on the PR (run 42968815830):The corpus ran its three replicate runs first and back to back. A KeyPackage's
createdAt,notBeforeandexpiresAtare whole seconds (src/mls_adapter/mod.rs,now_seconds * 1000). When the three replicates fell inside one second and a later run did not, those fields held still across the replicates and differed elsewhere, so the classifier read them as carrying every secret. Whether the test passed depended on where the second boundaries fell.What
matrix()now places the replicates at the first run, the last and one in the middle, and returns their indices. Runs execute in order, so a value read off a coarse clock either differs between the two ends and is fresh, or is the same in every run. Constant verdicts cannot change, because they depend only on the values and not on which runs are replicates; only a clock-dependent field can move from carrying to fresh.Test code only: the module is
#[cfg(test)].Not verified locally
No Rust toolchain on this machine; CI is the first build.
🤖 Generated with Claude Code