sm8250: support current ABL boot requirements - #98
Open
updawg wants to merge 3 commits into
Open
Conversation
updawg
force-pushed
the
agent/sm8250-16k-fat-clusters
branch
from
July 28, 2026 15:44
0ebadb9 to
8d1cf37
Compare
updawg
marked this pull request as ready for review
July 28, 2026 18:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-s 32tomkfs.fatfor every SM8250 boot filesystemRoot cause
FAT cluster size
The SM8250 ABL validates the boot partition's FAT cluster size and rejects anything other than 16,384 bytes with an
INVALID CLUSTER SIZEscreen. Without an explicit sectors-per-cluster setting,mkfs.fatselects the cluster size automatically and may create 32 KiB clusters for the 6 GiB boot filesystem.With 512-byte logical sectors,
-s 32makes each cluster 16,384 bytes.GRUB menu confirmation
Qualcomm UEFI reports the power button as
EFI_SCAN_SUSPEND(0x0102). The ABL handles that scan code as its confirmation action, but GRUB 2.12 does not map it and returnsGRUB_TERM_NO_KEY. As a result, the volume buttons can move through the combined SM8250 device menu while the power button cannot boot the highlighted entry.The SM8250-specific GRUB patch translates
EFI_SCAN_SUSPENDto carriage return, allowing the power button to act as Enter without changing other platforms.The power-on press can remain queued in the firmware input protocol when GRUB starts. Once the power button is mapped to Enter, that stale event would immediately boot the first menu entry before the menu appeared. Resetting the extended text-input protocol during GRUB console initialization discards pre-GRUB input while preserving subsequent button presses.
Impact
Retroid Pocket SM8250 devices can boot current images without manually reformatting the boot partition or reducing
grub.cfgto a single menu entry. The GRUB menu remains visible, the volume buttons move between entries, and a new power-button press boots the selected entry.Validation
genimage.cfgfiles use-F 32 -s 32 -n KNULLI