Skip to content

fix: replace Process.sleep(1) with nanosecond timestamp for card ID generation #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chenzihui222 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace Process.sleep(1) with nanosecond timestamp for card ID generation #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions lib/lulucat/fsrs_card.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,13 @@ defmodule Fsrs.Card do
# Private functions

defp generate_card_id do
# Epoch milliseconds of when the card was created.
# 创建卡片时的 epoch 毫秒时间戳。
card_id = System.system_time(:millisecond)

# Wait 1 ms to prevent potential card_id collision on next card creation.
# 等待 1 毫秒，防止下一次创建卡片时发生 card_id 冲突。
Process.sleep(1)

card_id
# Use nanosecond timestamp combined with a random component for unique IDs.
# This avoids Process.sleep(1) bottleneck while maintaining uniqueness.
# 使用纳秒时间戳结合随机组件生成唯一ID，避免 Process.sleep(1) 的性能瓶颈。
timestamp = System.system_time(:nanosecond)
random_component = :rand.uniform(1000)

Bitwise.bxor(timestamp, random_component)
end

defp handle_step(step, state) do
Expand Down