Integrate Auto Patcher into OpenAnt - #197
Conversation
Review: Integrate Auto Patcher (#197) — REQUEST CHANGES⚠ Snapshot caveat — please read before the findings. Since #197 was opened, two feature PRs Thanks @elaav. Reviewed by cloning This review reports the defects (what breaks, where, and the reproduction); it intentionally Scope: we opened the verdict-eligibility + trust-signal + grounding + diff/hygiene paths.
What this PR gets right (verified, no hedge)
Merge blockers — the 5 HIGH🔴 F-23 (P0, headline) — Trust signals fail open when the applicability check errors/times out. 🔴 F-25 — 🔴 F-29 (fail-silent) — The fence regex silently truncates the diff, so the real fix vanishes. 🔴 F-18 (security) — Symlink-following path traversal reads out-of-repo files into the LLM prompt. 🔴 F-01 — Repo grounding fails open to the current directory. 🟠 MEDIUM (20) — full list + exact anchors in the attached registry; the notable ones:
Nice-to-have (LOW/NIT follow-ups, not merge gates)Fence-injection in the rendered markdown · diff One framing note (not a code defect)The Trust-Report top-line Severity & scopeThe 5 HIGH (F-23, F-29, F-25, F-18, F-01) are the merge-blockers; the MEDIUM cluster next; the Line-anchored findings (file:line for every finding)Each comment states the defect and its evidence only — no remediation direction (that's in the internal registry).
(F-08/F-09/F-10 are follow-up nits mentioned in the summary; add inline only if you want them line-anchored.) |
Review follow-up (round 9) — 4 additional findings on #197A delta on the main consolidated review. Same method: each finding reproduced first-hand at #197 head
MEDIUM
LOW
Severity by the same rule as the main review — current = min(claimed, evidence-tier-cap); all four are exec-proven (reproduced first-hand at |
- add patch CLI command - merge Auto Patcher engine - generate Trust Reports for findings - add integration tests and live smoke validation
- Fail closed when applicability is unavailable (F-23) - Treat unavailable impact analysis as Not Verified (F-24) - Enforce explicit allowlists for Deploy After Validation (F-37) - Document recommendation policy invariants - Add boundary and regression tests for trust policy
Review follow-up (round 8) — 4 additional findings on #197A further delta on the main consolidated review (companion to the round-9 follow-up). Same method: each finding reproduced first-hand at #197 head
These cluster in the patch-hygiene parser — three false positives that block or downgrade a correct patch — plus one LLM-response parser bug. HIGH
MEDIUM
Severity by the same rule as the main review — current = min(claimed, evidence-tier-cap); all four are exec-proven (reproduced first-hand at |
Summary
This PR integrates the Auto Patcher research project into OpenAnt as a new
openant patchcommand.The new workflow generates evidence around AI-generated patches rather than automatically applying them. It produces a candidate patch, evaluates it using deterministic validation and adversarial review, and generates a Trust Report to help humans decide whether the patch should be trusted.
The target repository is never modified.
New workflow
What's included
openant patchCLI commandValidation
Validated with:
Design principles
This feature intentionally does not:
Its purpose is to generate evidence that helps humans decide whether an AI-generated patch should be trusted.
Follow-up work
This PR focuses on the integration itself.
Potential follow-ups include: