Skip to content

chore: handle ineligible_guides in guides fetch response#844

Open
thomaswhyyou wants to merge 4 commits intothomas-kno-11142-sdk-guide-toolbar-v2-poc-1from
thomas-kno-11142-sdk-guide-toolbar-v2-poc-4
Open

chore: handle ineligible_guides in guides fetch response#844
thomaswhyyou wants to merge 4 commits intothomas-kno-11142-sdk-guide-toolbar-v2-poc-1from
thomas-kno-11142-sdk-guide-toolbar-v2-poc-4

Conversation

@thomaswhyyou
Copy link
Contributor

@thomaswhyyou thomaswhyyou commented Feb 2, 2026

Description

This PR updates the guide client so it reads ineligible_guides from the fetch endpoint response and stores into the client state store, to prep ahead of the toolbar changes in downstream PRs.

As a reminder, this new field was introduced recently (here) to expose "ineligible markers", a minimal payload that explains which guide was evaluated ineligible for what reason. This information was previously inaccessible to the outside callers, but we want to surface it in the guide toolbar.

@linear
Copy link

linear bot commented Feb 2, 2026

@vercel
Copy link

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Feb 3, 2026 9:05pm
javascript-nextjs-example Ready Ready Preview, Comment Feb 3, 2026 9:05pm
javascript-slack-connect-example Ready Ready Preview, Comment Feb 3, 2026 9:05pm
javascript-slack-kit-example Ready Ready Preview, Comment Feb 3, 2026 9:05pm

Request Review

Copy link
Contributor Author

thomaswhyyou commented Feb 2, 2026

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2026

⚠️ No Changeset found

Latest commit: 2c0551f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thomaswhyyou thomaswhyyou changed the base branch from thomas-kno-11142-sdk-guide-toolbar-v2-poc-1 to graphite-base/844 February 2, 2026 20:47
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-4 branch from 34821df to 7963ad8 Compare February 2, 2026 20:47
@thomaswhyyou thomaswhyyou changed the base branch from graphite-base/844 to thomas-kno-11142-sdk-guide-toolbar-v2-poc-1 February 2, 2026 20:47
@thomaswhyyou thomaswhyyou changed the title handle ineligible_guides field in the guides fetch resp chore: handle ineligible_guides in guides fetch response Feb 2, 2026
@thomaswhyyou
Copy link
Contributor Author

@cursor review

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (thomas-kno-11142-sdk-guide-toolbar-v2-poc-1@8c99027). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                              Coverage Diff                               @@
##             thomas-kno-11142-sdk-guide-toolbar-v2-poc-1     #844   +/-   ##
==============================================================================
  Coverage                                               ?   68.45%           
==============================================================================
  Files                                                  ?      193           
  Lines                                                  ?     8052           
  Branches                                               ?     1066           
==============================================================================
  Hits                                                   ?     5512           
  Misses                                                 ?     2515           
  Partials                                               ?       25           
Files with missing lines Coverage Δ
packages/client/src/clients/guide/client.ts 88.64% <100.00%> (ø)
packages/client/src/clients/guide/types.ts 100.00% <ø> (ø)

@thomaswhyyou
Copy link
Contributor Author

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@thomaswhyyou thomaswhyyou marked this pull request as ready for review February 3, 2026 21:50
@thomaswhyyou thomaswhyyou requested review from a team, andy-knock, connorlindsey and kylemcd and removed request for a team February 3, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants