Repository navigation
fix: 入力の書式の例として書いた数とメールアドレスを指摘しない(#89、#90) - #91
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🙋 誰が出すか(Author)
✍️ 人が書く要約(Human-authored summary)
👏 解決する issue / Resolved Issues
📝 関連する issue / Related Issues
⛏ 変更内容 / Details of Changes
入力の書式の例として書いた数とメールアドレスが、誤って指摘されていた。どちらも、画面に入れる書式のまま書く必要があり、書き換えると例として成り立たない。
#89(NOT-012、NOT-013):次の数を、書式の例とみなして指摘しない。NOT-012とNOT-013で扱いをそろえた(
evaluators/lib/numbers.js)。#90(MKD-010):markdownlintのMD034の指摘のうち、次のメールアドレスを
score.mjsで外す。example.com、example.net、example.org、example.jp、*.example)例ではない数(「予算は1200000円」)と、ふつうのメールアドレス(
taro@foo.co.jp)は、これまでどおり指摘する。rules/notation.md(NOT-012)とrules/markup.md(MKD-010)の注記と、evaluators/README.mdに、除く形を書いたtests/score.test.mjsに、各Issueの再現手順を元にしたテストを足した🔎 既存のPR / Existing PRs
🔍 確認したこと / Verification
skills/docs-rules/rules/のルールに照らして点検した(node --test tests/*.test.mjsの採点のテストを含め、69件が通った).claude-plugin/やスキルの置き場所を変えた場合、CONTRIBUTING.mdの「プラグイン配布の検証」を通した(claude plugin validate .が通った)python3 tests/test_skill_size.pyを通した🤖 Generated with Claude Code