Restore zip/unzip in ci-tools image#194
Merged
Merged
Conversation
The 5.4 rebuild (#189) moved luarocks and gcc to the throwaway builder stage. zip and unzip had only ever been present as transitive apt deps of luarocks in the final image, so they silently dropped out. Both are part of the tool contract downstream bats suites depend on to assemble and inspect archive-format fixtures (ODT/DOCX/EPUB); their absence surfaces as `zip: command not found` (status 127). Request them explicitly so a future dependency shuffle can't drop them again, assert them in verify.sh, and list them in the README tool inventory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Lua 5.4 rebuild (#189) dropped
zipandunzipfromci-tools:latest, breaking downstream bats suites that assemble and inspect archive-format fixtures (ODT/DOCX/EPUB). This restores both so the image honors its tool contract again.Related Issues
Fixes #192
Changes
zipandunzipexplicitly in the final-stage apt block. They had only ever been present as transitive deps ofluarocks, which Migrate ci-tools to Lua 5.4 and eliminate kernel-header CVEs #189 moved to the throwaway builder stage — so they silently disappeared.scripts/ci-tools/verify.shso a future dependency shuffle failsmake verifyinstead of surfacing downstream as status 127.Further Comments
Verified by inspection against the pre-5.4 Dockerfile, which confirms
luarocks/gcc(and their transitivezip/unzip) lived in the final image before #189. The live check runs inpublish.yml, which builds the updated image single-platform and runsmake verifyagainst it. PR CI's lint/bats jobs run inside the stale published image but don't touch these tools.