Repository navigation
fix(cache): remove stale service address indexes - #1955
sivakumar-mahalingam wants to merge 3 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Sivakumar Mahalingam <36898056+sivakumar-mahalingam@users.noreply.github.com>
5585e63 to
b298c47
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Signed-off-by: Sivakumar Mahalingam <36898056+sivakumar-mahalingam@users.noreply.github.com>
|
The Istio 1.27 IPv6 E2E check failed in TestMixNsAndServiceWaypoint because X-Request-Id was missing. The same test passed on the preceding run with identical code. Could a maintainer rerun the failed job? |
Signed-off-by: Sivakumar Mahalingam <36898056+sivakumar-mahalingam@users.noreply.github.com>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Cleans up address indexes belonging to the previous version of a service before indexing an updated service. This prevents removed addresses from continuing to resolve through
servicesByAddrorservicesByIPwhile preserving addresses reassigned to another service.Adds regression tests covering stale index removal and address reassignment.
Which issue(s) this PR fixes:
Fixes #1954
Special notes for your reviewer:
The update path reuses the existing
deleteAddrownership checks. Tests cover both network-address and IP-only lookups.Does this PR introduce a user-facing change?:
Yes.