Skip to content

fix(ctl): preserve waypoint labels with revision - #1953

Open
sivakumar-mahalingam wants to merge 3 commits into
kmesh-net:mainfrom
sivakumar-mahalingam:fix/waypoint-preserve-labels
Open

sivakumar-mahalingam wants to merge 3 commits into
kmesh-net:mainfrom
sivakumar-mahalingam:fix/waypoint-preserve-labels

Conversation

@sivakumar-mahalingam

@sivakumar-mahalingam sivakumar-mahalingam commented Sep 20, 2026 •

Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it:

Preserves existing Gateway labels when adding istio.io/rev, so using --for and --revision together retains both labels. Adds a focused regression test covering both flags, each flag separately, and neither flag.

Which issue(s) this PR fixes:

Fixes #1952

Does this PR introduce a user-facing change?:

Fix `kmeshctl waypoint` generation to preserve the `istio.io/waypoint-for` label when `--revision` is also specified.

Tests:

  • go test -count=1 ./ctl/waypoint
  • go vet ./ctl/waypoint

Signed-off-by: Sivakumar Mahalingam <36898056+sivakumar-mahalingam@users.noreply.github.com>
@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Sep 20, 2026
@kmesh-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign supercharge-xsy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot

Copy link
Copy Markdown
Collaborator

Welcome @sivakumar-mahalingam! It looks like this is your first PR to kmesh-net/kmesh 🎉

@codecov

codecov Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.62%. Comparing base (09e96d3) to head (5eb7809).
⚠️ Report is 3 commits behind head on main.
see 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60881fc...5eb7809. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Sivakumar Mahalingam <36898056+sivakumar-mahalingam@users.noreply.github.com>
@sivakumar-mahalingam

Copy link
Copy Markdown
Author

The two Istio 1.28 E2E jobs were cancelled at the workflow’s 40-minute timeout. DCO, builds, and the other E2E jobs passed. I don’t have permission to rerun the cancelled jobs. @nlgwcy @LiZhenCheng9527 Could you please rerun them?

Signed-off-by: Sivakumar Mahalingam <36898056+sivakumar-mahalingam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kmeshctl waypoint drops --for label when --revision is specified

2 participants