fix(ctl): preserve waypoint labels with revision - #1953
sivakumar-mahalingam wants to merge 3 commits into
Conversation
Signed-off-by: Sivakumar Mahalingam <36898056+sivakumar-mahalingam@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @sivakumar-mahalingam! It looks like this is your first PR to kmesh-net/kmesh 🎉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Signed-off-by: Sivakumar Mahalingam <36898056+sivakumar-mahalingam@users.noreply.github.com>
b6d01df to
74c3606
Compare
|
The two Istio 1.28 E2E jobs were cancelled at the workflow’s 40-minute timeout. DCO, builds, and the other E2E jobs passed. I don’t have permission to rerun the cancelled jobs. @nlgwcy @LiZhenCheng9527 Could you please rerun them? |
Signed-off-by: Sivakumar Mahalingam <36898056+sivakumar-mahalingam@users.noreply.github.com>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Preserves existing Gateway labels when adding
istio.io/rev, so using--forand--revisiontogether retains both labels. Adds a focused regression test covering both flags, each flag separately, and neither flag.Which issue(s) this PR fixes:
Fixes #1952
Does this PR introduce a user-facing change?:
Tests:
go test -count=1 ./ctl/waypointgo vet ./ctl/waypoint