fix(secret): print confirmation on IPsec secret create/update - #1941
fix(secret): print confirmation on IPsec secret create/update#1941bhumikadangayach wants to merge 1 commit into
Conversation
Signed-off-by: Bhumika Dangayach <139267865+bhumikadangayach@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Fixes #1940
kmeshctl secret create printed nothing on success - no indication whether it created a new secret or rotated an existing one, or what the new SPI is. Running create twice silently rotated the live key with zero output.
CreateOrUpdateSecret in ctl/secret/secret.go returned silently after both the Create and Update branches. Added a fmt.Printf after each confirming the action and SPI.
Verified locally against a kind cluster:
$ kmeshctl secret create
IPsec secret created (SPI: 1)
$ kmeshctl secret create --key=...
IPsec secret updated (SPI: 2)