Skip to content

fix(secret): print confirmation on IPsec secret create/update - #1941

Draft
bhumikadangayach wants to merge 1 commit into
kmesh-net:mainfrom
bhumikadangayach:fix/secret-create-silent-success
Draft

fix(secret): print confirmation on IPsec secret create/update#1941
bhumikadangayach wants to merge 1 commit into
kmesh-net:mainfrom
bhumikadangayach:fix/secret-create-silent-success

Conversation

@bhumikadangayach

Copy link
Copy Markdown

Fixes #1940

kmeshctl secret create printed nothing on success - no indication whether it created a new secret or rotated an existing one, or what the new SPI is. Running create twice silently rotated the live key with zero output.

CreateOrUpdateSecret in ctl/secret/secret.go returned silently after both the Create and Update branches. Added a fmt.Printf after each confirming the action and SPI.

Verified locally against a kind cluster:

$ kmeshctl secret create
IPsec secret created (SPI: 1)

$ kmeshctl secret create --key=...
IPsec secret updated (SPI: 2)

Signed-off-by: Bhumika Dangayach <139267865+bhumikadangayach@users.noreply.github.com>
@kmesh-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign supercharge-xsy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.58%. Comparing base (c6357aa) to head (96da608).
⚠️ Report is 14 commits behind head on main.
see 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec501a9...96da608. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kmeshctl secret create gives no output on success, silently rotates existing IPsec key

2 participants