test(ctl/dump): add unit tests for kmeshctl dump table rendering - #1931
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
Covers uint32ToIPStr, printDualEngineTable, and printKernelNativeTable, including empty and malformed-JSON inputs that fall back to raw output. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
Collaborator
|
Welcome @magic-peach! It looks like this is your first PR to kmesh-net/kmesh 🎉 |
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
ctl/dumphas no unit test coverage for its output formatting:uint32ToIPStr,printDualEngineTable, andprintKernelNativeTableare pure functions thatparse a JSON dump and render it as a table, but a regression there ships
undetected until someone notices
kmeshctl dumpoutput looks wrong.This adds table-driven unit tests for:
uint32ToIPStr: zero, loopback, private, and broadcast addresses.printDualEngineTable: workloads/services/policies render correctly, anempty dump prints nothing, and malformed JSON falls back to echoing the
raw body instead of silently dropping the operator's data.
printKernelNativeTable: cluster/route config renders correctly, andmalformed JSON falls back to the raw body.
No production code changes.
Which issue(s) this PR fixes:
N/A — related to the test gap noted in #1819, but scoped to unit tests for
the existing table-rendering helpers rather than e2e coverage.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: