Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ec5cc8c to
75b40d4
Compare
8893a13 to
d345b62
Compare
a3999bb to
8dfac19
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
2af6a5e to
d4dcb94
Compare
|
Is this PR still a draft? |
|
hi @LiZhenCheng9527 The reason it's still marked as a Draft is that I am currently blocked from clicking the 'Ready for Review' button because I've hit the open pull request limit for the repository (this is my 6th open PR). I have 2 other open PRs that already have the lgtm label. Could you please merge those? Merging the approved ones will free up my limit and allow me to mark this PR as ready. Thanks |
7b06e5a to
9c64208
Compare
9c64208 to
d52e4fd
Compare
d52e4fd to
f969a47
Compare
f969a47 to
18ee385
Compare
18ee385 to
9d682a8
Compare
9d682a8 to
196509d
Compare
196509d to
4029db0
Compare
4029db0 to
3529624
Compare
Signed-off-by: devGPP23 <gauravpatil232005@gmail.com>
3529624 to
748c39e
Compare
Problem
While looking into the requirements for the upcoming MCP server implementation (Issue #1800), I noticed that we needed a way to retrieve all mesh namespaces (specifically for Tool #10:
get_mesh_namespaces). However, there was no native CLI command available to list the namespaces that are actively enrolled in Kmesh, forcing users to rely on manualkubectlqueries.If a user tried to query namespaces via the CLI, it just failed:
Solution
I added a new
kmeshctl namespace listsubcommand to solve this.Here is exactly what I did:
namespacesubcommand which queries the Kubernetes API directly.istio.io/dataplane-mode=Kmeshlabel so it only returns namespaces that are actually enrolled in the mesh.tabwritertable that displays the namespace name and explicitly shows if there is a waypoint attached by checking theistio.io/use-waypointlabel.This PR lays the exact groundwork needed so that the MCP server can directly wrap this CLI command to discover namespaces!
User-Facing Changes
Users can now easily discover which namespaces are enrolled in Kmesh and see their waypoint status at a glance without having to run complex
kubectl get ns -l ...queries.Terminal Output:
When there are Kmesh-enrolled namespaces in the cluster: