Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@R4R3D1FF ci are failing, so please fix it .. |
37c93c9 to
bcf02e8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Should work now @yashisrani |
| } | ||
|
|
||
| cgopt := link.CgroupOptions{ | ||
| Path: "/sys/fs/cgroup", |
There was a problem hiding this comment.
Shouldn't it be cgroup2?
There was a problem hiding this comment.
I don't think it matters for the focus of this test since it's only supposed to test whether BpfProgUpdate properly replaces the program so that it is removed after no link points to it.
Should I still replace it anyway? (even though it has no actual affect on the functioning of the test)
8ec68f4 to
0de4347
Compare
Signed-off-by: R4R3D1FF <mausam191003@gmail.com>
…sh restart Signed-off-by: R4R3D1FF <mausam191003@gmail.com>
Signed-off-by: R4R3D1FF <mausam191003@gmail.com>
Signed-off-by: R4R3D1FF <mausam191003@gmail.com>
… not already mounted Signed-off-by: R4R3D1FF <mausam191003@gmail.com>
Signed-off-by: R4R3D1FF <mausam191003@gmail.com>
0de4347 to
78f4ad4
Compare
Signed-off-by: R4R3D1FF <mausam191003@gmail.com>
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Adds tests for kmesh restart ensuring no duplicate program is present.
Which issue(s) this PR fixes:
Fixes #799
Special notes for your reviewer:
Does this PR introduce a user-facing change?: