Skip to content

Allow multiple blanks for handles#8

Open
garethson wants to merge 1 commit into
kmcphillips:masterfrom
garethson:allow-nil
Open

Allow multiple blanks for handles#8
garethson wants to merge 1 commit into
kmcphillips:masterfrom
garethson:allow-nil

Conversation

@garethson

Copy link
Copy Markdown
Collaborator

Allows a blank permalink if from is blank.

@kmcphillips

@kmcphillips

Copy link
Copy Markdown
Owner

What is your use case for allowing blank permalinks? It means this object now cannot be found by its permalink. Which is counter intuitive.

@kmcphillips

Copy link
Copy Markdown
Owner

We've got a Travis CI problem on gems and ruby versions. I'll dig into that.

@kmcphillips

Copy link
Copy Markdown
Owner

Rebase master to get #9 to fix CI.

@garethson

Copy link
Copy Markdown
Collaborator Author

My use case is for when the object is not yet "ready" for public consumption, and the from data, in this case, the event name, is not yet filled out.

I'm wondering if I'm more after the ability to explicitly just call "build_permalink` with parameters. I don't want to overly complicate the configuration of this module.

@kmcphillips

Copy link
Copy Markdown
Owner

Yeah. I think that's more what you're describing.

If you allow a blank then you have a non-unique value in the table. If your record is not "ready" yet, it still has an id.

It sounds more like what you want is to recalculate the permalink when the record is "ready" to match the configured values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants