Repository navigation
fix: detach playback listeners before YouTube teardown - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a participant with a real YouTube player loaded could blank the page: the SDK was destroyed before playback subscriptions were removed, so listener cleanup threw while reading the invalid iframe. Source replacement and leaving a room used the same ordering.
Dispose playback listeners/timers before destroying YouTube, with one component cleanup shared by both teardown paths. Playback synchronization, permissions and the socket protocol are unchanged.
Validation: real YouTube SDK source replacement and removal pass locally. A strict SDK fixture rejects calls after destruction and covers source replacement, removal and leaving. Lint/typecheck, 203 unit/integration tests, production build and 37/37 browser tests pass. Both CI checks are green, including Docker build, non-root execution and health checks.
Found during live QA of the requested be37ece deployment. Repeat production verification after deploying the exact merged fix SHA.