feat: Add create-style filter items to transporter, greedy familiar and all worker spirits that pick up items.#1606
feat: Add create-style filter items to transporter, greedy familiar and all worker spirits that pick up items.#1606klikli-dev wants to merge 102 commits intoversion/26.1.2from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new filtering system for spirits using 'List' and 'Attribute' filters, replacing the previous tag-based filtering. It includes necessary infrastructure updates, such as adding the 'code-defined-gui' dependency, updating GUI rendering logic, and modifying spirit entity data handling. My feedback highlights concerns regarding the reduction of filter slots from 14 to 1, which may cause data loss for existing entities, and suggests verifying if migration logic is required.
| TagValueOutput tagOutput = TagValueOutput.createWithContext(ProblemReporter.DISCARDING, SpiritEntity.this.level().registryAccess()); | ||
| this.serialize(tagOutput); | ||
| SpiritEntity.this.entityData.set(FILTER_ITEMS, tagOutput.buildResult().toString()); | ||
| SpiritEntity.this.entityData.set(FILTER_ITEM, tagOutput.buildResult().toString()); |
There was a problem hiding this comment.
The filterItemStackHandler is initialized with a size of 1, but the previous code used MAX_FILTER_SLOTS (14). Ensure that this reduction in filter capacity is intentional and does not break existing spirit configurations.
| String compoundStr = this.entityData.get(FILTER_ITEM); | ||
| try { | ||
| CompoundTag compound = compoundStr.isEmpty() ? new CompoundTag() : TagParser.parseCompoundFully(compoundStr); | ||
| compound.putInt("Size", 1); |
There was a problem hiding this comment.
The deserialization logic now forces a size of 1 for the filter handler. If this entity previously supported more slots, this will truncate existing data. Verify if migration logic is needed for existing entities.
|
|
||
| @Override | ||
| public int getMaxStackSize() { | ||
| return 1; |
There was a problem hiding this comment.
The filter slot is hardcoded to a max stack size of 1. Ensure this is consistent with the intended behavior for all filter types, as some might support larger stacks.
1 participant
No description provided.