Add arm64 go feature id#175
Conversation
Adds the following: ```go // ARM64Level returns the ARMv8/ARMv9 architecture version supported by the CPU // as (major, minor), e.g. 8, 4 for ARMv8.4-A or 9, 0 for ARMv9.0-A. // Only mandatory user-space instruction features are considered, so the result // is the highest level whose required instructions are all present. // Returns 0, 0 on non-arm64 CPUs or when feature detection was unavailable. func (c CPUInfo) ARM64Level() (major, minor int) // GOARM64 returns a value usable as the GOARM64 build setting for the detected // CPU, e.g. "v8.4" or "v9.0,crypto". The ",crypto" suffix is appended when AES, // PMULL, SHA1 and SHA256 are all present; the ",lse" suffix is appended in the // rare case LSE is present without the rest of the ARMv8.1 feature set. // Returns "" on non-arm64 CPUs or when feature detection was unavailable. // See https://go.dev/wiki/MinimumRequirements#arm64 func (c CPUInfo) GOARM64() string ``` Fixes #159
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds 13 new ARM64 ChangesARM64 architecture level detection and GOARM64 support
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 514: The ARM features table in README.md is missing periods after the
"etc" abbreviation at multiple locations. Add a period before the closing
parenthesis to change "etc)" to "etc.)" at all affected lines: line 514 in the
FRINTTS entry, line 516, line 519, and line 521. This follows American English
convention that requires periods after abbreviations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c5a60985-58b8-4902-95e2-5dd3164a9fbd
📒 Files selected for processing (5)
README.mdcmd/cpuid/main.gocpuid.gocpuid_test.goos_linux_arm64.go
🚧 Files skipped from review as they are similar to previous changes (4)
- cmd/cpuid/main.go
- cpuid.go
- cpuid_test.go
- os_linux_arm64.go
Adds the following:
Fixes #159
Summary by CodeRabbit
New Features
GOARM64(including in-jsonoutput).Bug Fixes
Documentation
Chores
noasmbuild tag).