Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| async function dumpDom(page, scene, outDir, step) { | ||
| const select = step.select ?? "body *"; | ||
| const rows = | ||
| await page.js(`(() => Array.from(document.querySelectorAll(${JSON.stringify(select)}), (el) => { |
| focusVisible: el.matches(":focus-visible"), | ||
| hover: el.matches(":hover"), | ||
| rect: [r.x, r.y, r.width, r.height], | ||
| css: Object.fromEntries(${JSON.stringify(DOM_PROPS)}.map((p) => [p, cs[p]])), |
| /// `triggerCs2BridgeCheck(steamId)` (lines 89-115): App.svelte reacts to | ||
| /// `LoadingEvent::Cs2Check` with this. | ||
| pub fn check(&mut self, steam_id: impl Into<String>) { | ||
| self.queue.push_back(Cs2Operation::Check(steam_id.into())); |
| return false; | ||
| } | ||
| self.load_in_flight = true; | ||
| self.queue.push_back(Cs2Operation::Load); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Clanker Claude Opus 5.5 is responding on behalf of meetsu
Summary
the whole front-end is being ported to egui, one screen at a time, each checked pixel by pixel against the Tauri build so the switch can ship as a normal update. work in progress, not ready to merge.
crates/accshift-appholds the logic without UI: the backend trait with mock and real implementations, stores, i18n, account pipeline, actions, secure flows, and the lifecycle (updater on the samelatest.jsonand key, single instance, deep links). 592 tests.crates/accshift-eguiholds the UI: title bar, workspace grid with folder, back and full account cards (CS2 bridge badge, armed state) and the hover extension panel (warnings, note, CS2 level), the list view with its preview panel and sliding sections, the search field with Chromium's own clear button, the settings panel with its General, Platforms and Privacy tabs and the descriptor preview dialog, toasts, the context menu, the input and confirm dialogs, the command palette, the secure screen (PIN lock, AFK cover with the waving wordmark) and the streamer mode overlay.backdrop-filterandfilter: blur(), through a layer pass added to the vendored software rasterizer; the card's blur is cropped to its rounded box like Chromium's.text-shadowglows are rasterized from the glyph atlas and blurred the way Skia does (ui::text_shadow).transitionlists, the rest switches at once (controls::button).app/avatars.rs,ui::resample).accshift-appbefore any widget reads them, so Ctrl+K, Escape, Ctrl+Tab, Ctrl+F and the swallowed WebView shortcuts behave like the Tauri build; the arrows move a focus ring across the cards and Enter, F2 and Delete act on it.size=20width from the font and put the caret where Blink rounds it (TextStyle::text_field_width,controls::text_input).crates/accshift-egui/paritycaptures the Tauri app at the real device scale factor and diffs it against egui frames.tabular-numsmaps totnum).the Tauri side of the card focus was broken on main and is fixed in #95; this branch carries the same TS files so its references show the fixed behaviour.
to question: epaint is vendored for the glyph hook (upstream has no rasterizer extension point); it also lets trailing spaces hang past the wrap width, as CSS does, and passes a job's OpenType features to harfrust. the search clear button ships Chromium's two 28 px bitmaps under their BSD license, in
assets/chromium.Related issue
none
Tested on
Checklist
cargo testin both new cratesnot verified: the glow renderer against the references, macOS and Linux builds, an update from a Tauri install in a VM, the AFK and streamer waves and the card extension's open and close in motion (scenes run with animations off), the link and chip actions inside the extension (no mock account has one).
known difference: after the AFK cover leaves, WebView2 keeps the app rastered at its obscured
scale(1.01)and the text stays soft (still the case 1.8 s later); egui is sharp again at once.more captures