Unittest pytest example - #114
Open
VincentJilesen wants to merge 15 commits into
Open
Conversation
skapinga
reviewed
Sep 10, 2026
Collaborator
There was a problem hiding this comment.
De test controleert de functie created_project() in project.py
In de test ontbreekt de keuze applicatie afsluiten. Ook wordt het standaardgeval waarbij geen bekende keuze wordt teruggegeven niet getest. Lijkt me geen probleem
Collaborator
Author
There was a problem hiding this comment.
Het is een meerkeuze vraag dus er is geen onbekende keuze mogelijk.
skapinga
reviewed
Sep 10, 2026
Collaborator
There was a problem hiding this comment.
Implementatie van Mock is ok. Alleen de routeringslogica wordt getest. De echte request_binnenteenlijn_filepath en de import/write-logica blijven nog ongetest.
skapinga
self-requested a review
September 10, 2026 09:49
skapinga
approved these changes
Sep 10, 2026
skapinga
left a comment
skapinga
left a comment
Collaborator
There was a problem hiding this comment.
goede implementatie om de scope van de tests uit te breiden
skapinga
marked this pull request as ready for review
September 10, 2026 09:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Een paar voorbeelden van unittests met pytest.