Conversation
Start env, logging en geoprop_pipe package
* Tussenstand * Tussenstand * Added timestamps for the 3 limit states * Some logging changes * Problems tab weggewerkt voor quick overview possible issues * Start exporteren en visualiseren van resultaten * Beta grafiek, InputData-object en herstructureren geoprob_pipe-package * First figure finished * Finished first version of results overview flow chart * Emptied output dir * rm dir output * Added output dir to gitignore * Small TODOs * Start comparison OT en ProbLib with first unit test * Coverage issue? * Coverage issue? * Coverage issue? * Fixed coverage issue * Fixed coverage issue * Solving checkout issue * Solving checkout issue * Testing and coverage * Split unit testing workflows * Fixed setup unit test and coverage workflows * Start on BaseSystemRelibabilityCalculation * Finished parallel system, idea for piping child in progress * Finished parallel piping system child * Reliability calculations package structure and test setup defined * Asserts toegevoegd aan example system calculation * Beetje opschonen * Fixed assertions * Piping test input, maar uitkomst klopt nog niet * DeterministicSystemCalculation created + working example PipingSystemReliabilityCalculation. But unsure if input or piping models are correct * Collecting to dataframe finished * first readme to view * Nieuwe weergave * Nieuwe weergave * Nieuwe weergave * workflow added * Fix path issue * Prevent import * Update of TODO items in README * Naar single project (#10) * Single project system builder implemented, now ready for testing * nog niet volledig werkend * Small change in collect_todos-script * Small change in collect_todos-script * Small change in collect_todos-script * Small change in collect_todos-script * Exporteren resultaten klaar, structuur verbetered. Verder opruimen nog wel nodig * Voorlopig afgerond * fixed some small mistakes * Update of TODO items in README * verplaatsing van 2 bestanden * Update of TODO items in README * hfreq en beta export graphs func! (#12) * Aanpassing van Ardjan * hfreq grafiek afgerond! * hfreq en beta export graphs func! * small fixes * suggestie aanpassingen aan graphs * verbeterd * bijna afgerond * Added some future todos * Hfreq werkt en beta uittredenpunten grafiek * only small changes --------- Co-authored-by: ardjanmethorst <a.methorst@wsrl.nl> Co-authored-by: chrispijo <chrispitzalis@gmail.com> * Update of TODO items in README * Change pull request testing workflow --------- Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: Laura van der Doef <lvanderdoef@outlook.com> Co-authored-by: ardjanmethorst <a.methorst@wsrl.nl>
* Tussenstand * Tussenstand * Added timestamps for the 3 limit states * Some logging changes * Problems tab weggewerkt voor quick overview possible issues * Start exporteren en visualiseren van resultaten * Beta grafiek, InputData-object en herstructureren geoprob_pipe-package * First figure finished * Finished first version of results overview flow chart * Emptied output dir * rm dir output * Added output dir to gitignore * Small TODOs * Start comparison OT en ProbLib with first unit test * Coverage issue? * Coverage issue? * Coverage issue? * Fixed coverage issue * Fixed coverage issue * Solving checkout issue * Solving checkout issue * Testing and coverage * Split unit testing workflows * Fixed setup unit test and coverage workflows * Start on BaseSystemRelibabilityCalculation * Finished parallel system, idea for piping child in progress * Finished parallel piping system child * Reliability calculations package structure and test setup defined * Asserts toegevoegd aan example system calculation * Beetje opschonen * Fixed assertions * Piping test input, maar uitkomst klopt nog niet * DeterministicSystemCalculation created + working example PipingSystemReliabilityCalculation. But unsure if input or piping models are correct * Collecting to dataframe finished * first readme to view * Nieuwe weergave * Nieuwe weergave * Nieuwe weergave * workflow added * Fix path issue * Prevent import * Update of TODO items in README * Naar single project (#10) * Single project system builder implemented, now ready for testing * nog niet volledig werkend * Small change in collect_todos-script * Small change in collect_todos-script * Small change in collect_todos-script * Small change in collect_todos-script * Exporteren resultaten klaar, structuur verbetered. Verder opruimen nog wel nodig * Voorlopig afgerond * fixed some small mistakes * Update of TODO items in README * verplaatsing van 2 bestanden * Update of TODO items in README * hfreq en beta export graphs func! (#12) * Aanpassing van Ardjan * hfreq grafiek afgerond! * hfreq en beta export graphs func! * small fixes * suggestie aanpassingen aan graphs * verbeterd * bijna afgerond * Added some future todos * Hfreq werkt en beta uittredenpunten grafiek * only small changes --------- Co-authored-by: ardjanmethorst <a.methorst@wsrl.nl> Co-authored-by: chrispijo <chrispitzalis@gmail.com> * plotly werkt niet * interactive added * hfreq oude reset * tussenstand plotly betrouwbaarheidsindex * Finished TrajectNormering * Finished HFreq single interactive graph * Oude betrouwbaarheidsfiguren tijdelijk teruggezet --------- Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: Laura van der Doef <lvanderdoef@outlook.com> Co-authored-by: ardjanmethorst <a.methorst@wsrl.nl>
* added geopackage * First version of exporting spatial data (geopackage) * Added exporting validation messages of calculations * Finished exporting alphas, physical values and influence factors * Added graph physical values buitenwaterstand * Grotendeel feedback 2025-08-11 verwerkt * Some small changes for release
* Kleine aanpassingen aan de figuren * Small changes to gitignore * Added 224 as system unit test * 224 hrd excluded van gitignore * Small change to readme * Trigger toegevoegd voor bestanden bij unit tests * Small change * Figuur invloedsfactoren afgerond
* change on parameters initial input * changed scope_referentie and ondergrondscenario_naam to default value pd.NA to meet validation requirements * fix crash in geoprob_pipe due to validation errors * Validation issue fix * Added new test * Added new test * Build and run test * In progress: Vraag aan Sander * Update * Test Traject Normering --------- Co-authored-by: chrispijo <chrispitzalis@gmail.com>
* Initial commit * Initiatie workflow * v6 test * setup-python action update * setup-python action update * action update * action update
* verduidelijking validatie bericht * Assertion on geometry types from vakindeling projection * Controle of vakindeling samenvoegbaar is tot één lijn * Verduidelijking bericht * Polderpeil validatie toevoegd * gamma_korrel correctie * Bugfix traject pof>1 * Version up
| laag in de geopackage waar de lijn is opgeslagen. Color is de kleur van deze lijn in de map. """ | ||
|
|
||
| gdf_traject = gpd.read_file( | ||
| gdf_traject = read_file( |
Collaborator
There was a problem hiding this comment.
Ik ben hier meestal geen fan van omdat het nu niet meer duidelijk is waar deze functie vandaan komt. Komt het uit onze eigen code? Pandas? Geopandas?
VincentJilesen
approved these changes
Aug 14, 2026
VincentJilesen
left a comment
VincentJilesen
left a comment
Collaborator
There was a problem hiding this comment.
In principe, alles goed maar zie comments.
Collaborator
Author
Denk dat ik gewoon kan gaan mergen of niet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dit issue was opgelost voor de vakantie. Dacht al gemerged naar main, maar lijkt het toch niet op.
Zie toelichting in comments hieronder.
Ik zie nu dat het wel in main zit maar dat GitHub wel als files changed ziet. Ik snap niet precies hoe dat komt. Maar wellicht kun je @VincentJilesen toch kort reviewen, en dan merge ik het opnieuw.