Skip to content

add examples#37

Open
kriswep wants to merge 5 commits into
kkemple:masterfrom
kriswep:add-examples
Open

add examples#37
kriswep wants to merge 5 commits into
kkemple:masterfrom
kriswep:add-examples

Conversation

@kriswep

@kriswep kriswep commented Jun 17, 2018

Copy link
Copy Markdown

What did you do:

Added examples as suggested in #31, this closes #31.
The following three were added in an examples folder, shamlessly copied from your provided snack examples:

Tested all three successfully locally in an iOS and Android expo client.

I also added the examples folder to .npmignore for smaller user node_modules. This could be easily reverted, if you prefer to publish the examples along.

Does this relate to any issue(s)? If so which one(s)?

#31

Checklist:

  • I added link to related issue if there is one
  • I added a screenshot/gif (if appropriate)
  • I ran yarn lint and yarn flow
    • Ran it, but didn't commit changes, as they were unrelated to the added examples

@geminiyellow

Copy link
Copy Markdown

hi @kkemple thanks for your work, but, this repo still working?

@igmarinelli

Copy link
Copy Markdown

hi @kkemple could you please send the link of the players example? thx

@kkemple

kkemple commented May 28, 2019

Copy link
Copy Markdown
Owner

this looks great and I can merge if still working, @geminiyellow I haven't been maintaining this since im no longer working in RN but have been looking for maintainers. No one wants to so it sits.

@geminiyellow

Copy link
Copy Markdown

opps @kkemple , thanks for your reply. i m no longer working in RN, too. LOL.

@soluchok

Copy link
Copy Markdown

Hey, guys! How to fix a bug as you can see below, the issue is when you touch card rapidly it is not so smoothly like a native behavior
ezgif com-video-to-gif (1)
ezgif com-video-to-gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

This is an awesome library, can you guys put some example code here?

5 participants