Removed GameScene/ReplayManager/Runner cursor responsibilities#4
Open
thommell wants to merge 10 commits intokiwirew:indevfrom
Open
Removed GameScene/ReplayManager/Runner cursor responsibilities#4thommell wants to merge 10 commits intokiwirew:indevfrom
thommell wants to merge 10 commits intokiwirew:indevfrom
Conversation
code readability changes and added some small optimizations
I had to change a material transparency within the cursor trail, maybe check if it looks better? Rewrote cursor trail stuff from Runner.cs - Fixed a memory leak in the trail itself causing massive gradual lowering of frames when trail was on
thommell
changed the title
Author
|
Found some issues with the trail's detail and alpha values not being accounted for, drafting PR |
thommell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a CursorManager that handles the cursor.
Cursor trail:
(some formatting changes due to Rider's automatic formatting stuff, sorry)