Accessibility: TalkBack improvements — contentDescription, semantics, liveRegion - #89
Open
AbdulAziz-Hatem wants to merge 21 commits into
Open
Accessibility: TalkBack improvements — contentDescription, semantics, liveRegion#89AbdulAziz-Hatem wants to merge 21 commits into
AbdulAziz-Hatem wants to merge 21 commits into
Conversation
…, contacts, and folder selector
…a11y_permission_*, a11y_contact_photo)
…gion semantics, localized strings
…rch icon description
…ircularProgressIndicator semantics, dialog icons
…ics for TalkBack navigation
…les translations automatically
…ems, Role.RadioButton on contacts options, localized WarningCard contentDescription
…n param), use semantics {} without it
…gResource outside semantics block
…rt (shadows Icon param)
…(line 192 composable error)
…in this Compose version)
kitsumed
self-requested a review
August 5, 2026 22:39
Owner
|
… only accessibility changes in PR kitsumed#89)
# Conflicts: # app/src/main/java/com/kitsumed/shizucallrecorder/ui/screens/PermissionsScreen.kt
…ng/comments in touched files)
Contributor
Author
|
Thanks for the feedback! Both points are addressed:
Diff is now +91/−13 across 7 files, all accessibility-related. CI is verified passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TalkBack Accessibility Improvements
What this does
Adds
contentDescription,semantics, andliveRegionannotations across the Compose UI so TalkBack users can navigate and interact with the app effectively.Why needed
The app had zero uses of
Modifier.semanticsand almost nocontentDescriptionon interactive elements. TalkBack users could not:Files changed
values/strings.xmla11y_overlay_*,a11y_permission_*,a11y_contact_photo)RecordingOverlay.ktcontentDescriptionper state,liveRegion+stateDescriptionsemantics, localized drag handlePermissionsScreen.ktcontentDescriptionon status icons,CircularProgressIndicator, dialog iconsContactSelectionDialog.ktcontentDescriptionon contact photos and search iconSponsorScreen.ktSettingsScreen.ktWarningCardiconci-build.ymlBuild verification
CI build passes ✅ —
assembleDebug+Upload Debug APKboth succeed.Android documentation references
Note on translations
New strings were added only to
values/strings.xml(English). Weblate will handle translation to other languages automatically.AI disclosure
This PR was created with AI assistance (RikkaHub Agent). All code was reviewed for correctness before submission. CI build was verified passing.
Assisted-by: RikkaHub Agent