Repository navigation
fix(build): check Go sources out with LF on every platform - #24
Closed
Amazon2025 wants to merge 1 commit into
Closed
Amazon2025 wants to merge 1 commit into
Amazon2025 wants to merge 1 commit into
Conversation
core.autocrlf=true is the default on Windows, so every .go file was checked out with CRLF and gofmt -l listed the whole tree. The gofmt gate in CI runs on Linux, where the checkout is already LF, so the breakage only ever showed up for Windows contributors and only before they had edited a single line. Pinning eol=lf for *.go makes the Windows checkout byte-identical to what the gate expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core.autocrlf=true is the default on Windows, so every .go file was checked out with CRLF and gofmt -l listed the whole tree. The gofmt gate in CI runs on Linux, where the checkout is already LF, so the breakage only ever showed up for Windows contributors and only before they had edited a single line. Pinning eol=lf for *.go makes the Windows checkout byte-identical to what the gate expects.