Skip to content

fix: missing themedContext getter causes compilation errors#1490

Merged
kirillzyusko merged 2 commits into
mainfrom
fix/missing-themed-context-getter
Jun 9, 2026
Merged

fix: missing themedContext getter causes compilation errors#1490
kirillzyusko merged 2 commits into
mainfrom
fix/missing-themed-context-getter

Conversation

@kirillzyusko

@kirillzyusko kirillzyusko commented Jun 8, 2026

Copy link
Copy Markdown
Owner

📜 Description

Use getter for themedContext explicitly. Don't rely on auto-getters anymore.

💡 Motivation and Context

Closes #1489

📢 Changelog

Android

  • explicitly use getThemedContext getter;

🤔 How Has This Been Tested?

Tested via CI. Old RN versions works as expected.

📸 Screenshots (if appropriate):

image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko self-assigned this Jun 8, 2026
@kirillzyusko kirillzyusko added 🤖 android Android specific build error ❌ Anything that triggers build errors and prevent this library from being used labels Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

📊 Package size report

Current size Target Size Difference
318458 bytes 318366 bytes 92 bytes 📈

@kirillzyusko kirillzyusko force-pushed the fix/missing-themed-context-getter branch from 3139ef4 to d58b76d Compare June 8, 2026 11:50
@kirillzyusko kirillzyusko marked this pull request as ready for review June 8, 2026 13:08
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
  1. Incorrect Method Call for Themed Context
    Why: The code incorrectly calls getThemedContext() which may not be a valid method, leading to runtime errors if it doesn't exist.
    Fix: Replace getThemedContext().getDisplaySize() with the original themedContext.getDisplaySize().

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙏

@kirillzyusko

kirillzyusko commented Jun 8, 2026

Copy link
Copy Markdown
Owner Author

@cortinico do you need a new release? Will the current release without these changes block/break upcoming RN 0.86 release?

@cortinico

Copy link
Copy Markdown
Contributor

@cortinico do you need a new release? Will the current release without these changes block/break upcoming RN 0.86 release?

If you could make a new release it would be gold as it would render the nightlies green here: https://react-native-community.github.io/nightly-tests/

This is also not going to affect users on <= 0.86 but only on 0.87+ so not super urgent 👍

@cortinico

Copy link
Copy Markdown
Contributor

Also this is backward compatible, so you should be able to merge it and should not impact existing users

@kirillzyusko kirillzyusko merged commit 78c1f81 into main Jun 9, 2026
19 checks passed
@kirillzyusko kirillzyusko deleted the fix/missing-themed-context-getter branch June 9, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 android Android specific build error ❌ Anything that triggers build errors and prevent this library from being used

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OverKeyboardHostShadowNode: Function invocation 'getThemedContext()' expected.

2 participants