fix: missing themedContext getter causes compilation errors#1490
Merged
Conversation
Contributor
📊 Package size report
|
3139ef4 to
d58b76d
Compare
Contributor
|
cortinico
approved these changes
Jun 8, 2026
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this 🙏
Owner
Author
|
@cortinico do you need a new release? Will the current release without these changes block/break upcoming RN 0.86 release? |
Contributor
If you could make a new release it would be gold as it would render the nightlies green here: https://react-native-community.github.io/nightly-tests/ This is also not going to affect users on <= 0.86 but only on 0.87+ so not super urgent 👍 |
Contributor
|
Also this is backward compatible, so you should be able to merge it and should not impact existing users |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Use getter for
themedContextexplicitly. Don't rely on auto-getters anymore.💡 Motivation and Context
Closes #1489
📢 Changelog
Android
getThemedContextgetter;🤔 How Has This Been Tested?
Tested via CI. Old RN versions works as expected.
📸 Screenshots (if appropriate):
📝 Checklist