fix: prevent crash when KeyboardChatScrollView unmounted#1485
Merged
kirillzyusko merged 1 commit intoJun 4, 2026
Merged
Conversation
Contributor
📊 Package size report
|
KeyboardChatScrollView unmounted
KeyboardChatScrollView unmountedKeyboardChatScrollView unmounted
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed a crash on Android when using
KeyboardChatScrollView.💡 Motivation and Context
We may schedule a call to perform
scrollTolater. But if the component is unmounted, then we will get a crash.In this PR I'm adding a check to skip
scrollTooperation if view was unmounted.Based on bluesky-social/social-app#10673
📢 Changelog
JS
scrollToif ref is null;🤔 How Has This Been Tested?
There is no way to test it at the moment, but CI is green 🟢
📸 Screenshots (if appropriate):
📝 Checklist