fix: missing scroll animation when switching between inputs in KeyboardAwareScrollView#1484
Merged
kirillzyusko merged 3 commits intoJun 3, 2026
Conversation
…ardAwareScrollView`
Contributor
📊 Package size report
|
…xcluding removeGhostPadding shouldn't cause a test failure - maybe it's just a coincidence so let's verify if artificial delay will fix the issue
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed a problem with missing animation in
KeyboardAwareScrollViewwhen switching between fields.💡 Motivation and Context
The problem was because
removeGhostPaddingperformed a synchronousscrollTo(which overrides the effect of priorscrollTocall with animation).The fix is to skip the call when it's not necessary.
Additionally I tried to fix flakiness of
KeyboardAwareScrollViewStickyViewtests by increasing an interval between shared value update and call a function on a UI thread.Closes #1483
📢 Changelog
JS
runOnUIinrequestAnimationFrame;removeGhostPaddingonly when keyboard is hidden (e.height === 0)🤔 How Has This Been Tested?
Tested on iPhone 17 Pro (iOS 26.2) + e2e tests.
📸 Screenshots (if appropriate):
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-06-03.at.15.10.29.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-06-03.at.15.09.15.mov
📝 Checklist