Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
justnyx
commented
Mar 26, 2026
There was a problem hiding this comment.
Pull request overview
Implements band invitation/approval workflows and public visibility gating for bands, including UI changes and backend filtering based on approval and membership state.
Changes:
- Added band approval (
isApproved) and updated bands listing behavior based on approval + user role. - Introduced
PENDINGvsACCEPTEDband invitations with a 7-day “validity window” viacreatedAtfiltering. - Updated frontend UI to support inviting users, accepting/rejecting invites, and genre autocomplete suggestions.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| project_info/structure.md | Updates architecture/docs to reflect band approval + invite expiration support. |
| project_info/product.md | Updates product spec around band creation, admin approval, and invitations. |
| apps/frontend/src/types/band.ts | Extends types with isApproved, membership status union, and createdAt. |
| apps/frontend/src/components/band/create-band-dialog.tsx | Passes knownGenres into the band form for suggestions. |
| apps/frontend/src/components/band/band-row.tsx | Adds invite accept/reject UI, admin approval UI, and member display changes. |
| apps/frontend/src/components/band/band-form-dialog.tsx | Adds genre suggestion dropdown for band form. |
| apps/frontend/src/app/bands/page.tsx | Derives/passes knownGenres, adjusts empty state text, renders rows with per-row <tbody>. |
| apps/backend/src/bands/dto/update-band.dto.ts | Allows updating isApproved via DTO validation. |
| apps/backend/src/bands/bandsController.ts | Adds optional-auth GET /bands and invitation accept/reject authorization changes. |
| apps/backend/src/bands/bands.service.ts | Filters bands/memberships by approval + membership status with 7-day pending window. |
| apps/backend/src/auth/optional-jwt-auth.guard.ts | Adds guard to allow public access with optional JWT parsing. |
| apps/backend/src/auth/jwt.strategy.ts | Validates JWT user by fetching from DB and rejecting missing users. |
| apps/backend/prisma/schema.prisma | Adds Band.isApproved and BandMembership.createdAt. |
| apps/backend/prisma/migrations/20260323150841_add_created_at_to_band_membership/migration.sql | Adds createdAt column to BandMembership. |
| apps/backend/prisma/migrations/20260319132056_add_band_approval/migration.sql | Adds isApproved column to Band. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the following changes to the bands member invitation logic:
Tag hozzáadásabutton toTag meghívásaTag meghívásabutton