Skip to content

Feat/band improvements#92

Open
justnyx wants to merge 5 commits intomainfrom
feat/band_improvements
Open

Feat/band improvements#92
justnyx wants to merge 5 commits intomainfrom
feat/band_improvements

Conversation

@justnyx
Copy link
Copy Markdown
Collaborator

@justnyx justnyx commented Mar 23, 2026

Implemented the following changes to the bands member invitation logic:

  • Renamed the Tag hozzáadása button to Tag meghívása
  • Band members are now able to invite other users to their band with the Tag meghívása button
  • Invited users are not automatically be added to the band
  • Invited users are required to accept or reject the invitation
    • If they accept it, they are added to the band
    • If they reject it, they are removed from the band and their invite is deleted
  • Invites expire after a week, if the invited user doesn't respond

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mmmk-web-frontend Ready Ready Preview, Comment Apr 22, 2026 6:59pm

Request Review

Comment thread project_info/product.md Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements band invitation/approval workflows and public visibility gating for bands, including UI changes and backend filtering based on approval and membership state.

Changes:

  • Added band approval (isApproved) and updated bands listing behavior based on approval + user role.
  • Introduced PENDING vs ACCEPTED band invitations with a 7-day “validity window” via createdAt filtering.
  • Updated frontend UI to support inviting users, accepting/rejecting invites, and genre autocomplete suggestions.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
project_info/structure.md Updates architecture/docs to reflect band approval + invite expiration support.
project_info/product.md Updates product spec around band creation, admin approval, and invitations.
apps/frontend/src/types/band.ts Extends types with isApproved, membership status union, and createdAt.
apps/frontend/src/components/band/create-band-dialog.tsx Passes knownGenres into the band form for suggestions.
apps/frontend/src/components/band/band-row.tsx Adds invite accept/reject UI, admin approval UI, and member display changes.
apps/frontend/src/components/band/band-form-dialog.tsx Adds genre suggestion dropdown for band form.
apps/frontend/src/app/bands/page.tsx Derives/passes knownGenres, adjusts empty state text, renders rows with per-row <tbody>.
apps/backend/src/bands/dto/update-band.dto.ts Allows updating isApproved via DTO validation.
apps/backend/src/bands/bandsController.ts Adds optional-auth GET /bands and invitation accept/reject authorization changes.
apps/backend/src/bands/bands.service.ts Filters bands/memberships by approval + membership status with 7-day pending window.
apps/backend/src/auth/optional-jwt-auth.guard.ts Adds guard to allow public access with optional JWT parsing.
apps/backend/src/auth/jwt.strategy.ts Validates JWT user by fetching from DB and rejecting missing users.
apps/backend/prisma/schema.prisma Adds Band.isApproved and BandMembership.createdAt.
apps/backend/prisma/migrations/20260323150841_add_created_at_to_band_membership/migration.sql Adds createdAt column to BandMembership.
apps/backend/prisma/migrations/20260319132056_add_band_approval/migration.sql Adds isApproved column to Band.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/backend/src/bands/bandsController.ts Outdated
Comment thread apps/backend/src/bands/bands.service.ts
Comment thread apps/backend/src/bands/bandsController.ts
Comment thread apps/frontend/src/components/band/band-form-dialog.tsx
Comment thread apps/frontend/src/components/band/band-row.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants