Skip to content

Added MAIL to authschScopes to avoid having constraint violations#1030

Merged
SzBeni2003 merged 1 commit intostagingfrom
fix/authsch-scopes
Apr 25, 2026
Merged

Added MAIL to authschScopes to avoid having constraint violations#1030
SzBeni2003 merged 1 commit intostagingfrom
fix/authsch-scopes

Conversation

@SzBeni2003
Copy link
Copy Markdown
Contributor

@SzBeni2003 SzBeni2003 commented Apr 25, 2026

Summary by CodeRabbit

  • New Features
    • Login process now includes email access permissions in the authentication request.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c498f8a9-f389-4d40-8d08-6a5296e2cec7

📥 Commits

Reviewing files that changed from the base of the PR and between 6be8ff1 and d0defcf.

📒 Files selected for processing (1)
  • backend/src/main/kotlin/hu/bme/sch/cmsch/component/login/LoginComponent.kt

📝 Walkthrough

Walkthrough

The default OAuth scope configuration for AuthSCH login is updated to include the Scope.MAIL scope alongside existing scopes. This enables mail-related data access by default in the authentication flow.

Changes

Cohort / File(s) Summary
AuthSCH Scope Configuration
backend/src/main/kotlin/hu/bme/sch/cmsch/component/login/LoginComponent.kt
Added Scope.MAIL to the default authschScopesRaw setting, expanding the default OAuth scopes requested during authentication.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A whisker-twitch of scope so fine,
Mail now flows in OAuth's line,
Default config, small but grand,
One hop forward, code so planned! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding MAIL to authschScopes to resolve constraint violations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/authsch-scopes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmsch-cst Ready Ready Preview, Comment Apr 25, 2026 9:22am
cmsch-felezobal Ready Ready Preview, Comment Apr 25, 2026 9:22am
cmsch-golyakorte Ready Ready Preview, Comment Apr 25, 2026 9:22am
cmsch-skktv Ready Ready Preview, Comment Apr 25, 2026 9:22am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AuthSch logins don't give email value for user, therefore resulting in constraint violation

1 participant