fix(create-plugin): Weak RSA Key Size#3780
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The generatePrivateKey function uses RSA with 1024-bit key size (b: 1024), which is considered cryptographically weak by modern standards. NIST recommends at least 2048-bit keys for RSA. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
tomaioo
requested review from
chihiro-adachi and
nameless-mc
and removed request for
a team
Contributor
|
@tomaioo |
chihiro-adachi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Weak RSA Key Size
Problem
Severity:
Medium| File:packages/create-plugin/src/privateKey.ts:L10The generatePrivateKey function uses RSA with 1024-bit key size (b: 1024), which is considered cryptographically weak by modern standards. NIST recommends at least 2048-bit keys for RSA.
Solution
Increase the RSA key size to at least 2048 bits: new RSA({ b: 2044 }) or use { b: 2048 }
Changes
packages/create-plugin/src/privateKey.ts(modified)