Refactor/request type consistency - #60
Merged
Merged
Conversation
Cteklitz
marked this pull request as ready for review
March 11, 2026 19:29
kinneyan
reviewed
Mar 16, 2026
kinneyan
reviewed
Mar 16, 2026
This reverts commit 3b10069.
…ce_id to be a url parameter
Breaks ALL tests but we will simply have to rewrite them. Many of the endpoints need to be modified to fit new spec, and many are missing and need to be added
Cteklitz
force-pushed
the
refactor/request-type-consistency
branch
from
March 17, 2026 20:38
8e2d2f6 to
ad478f8
Compare
Remove implementation-testing unit tests (mocked view tests, serializer field introspection, Meta attribute assertions) that provide no real signal and duplicate integration test coverage. Fix assertTrue(False/True) anti-patterns across integration tests, replacing them with assertFalse/assertTrue(Model.objects.filter(...).exists()). Add cross-workspace isolation tests for all resource-level endpoints (role CRUD, shift CRUD, member roles, permissions), verifying that a privileged member of workspace B cannot operate on resources in workspace A. Fix bug in MemberPermissionsView where WorkspaceMember.DoesNotExist was unhandled when the requester had no membership in the target workspace, causing a 500 instead of 403.
test: overhaul test suite for quality and coverage
Cteklitz
force-pushed
the
refactor/request-type-consistency
branch
from
March 18, 2026 19:37
332eb61 to
a879a24
Compare
…when not a member
Cteklitz
marked this pull request as ready for review
March 23, 2026 19:50
kinneyan
requested changes
Mar 28, 2026
kinneyan
left a comment
kinneyan
left a comment
Owner
There was a problem hiding this comment.
Couple comments that I must have missed before. After these 4 will approve. Sorry.
Owner
|
To resolve the conflicts you'll probably need to manually change the line number fixes that I did and then run black to make it do that and then can pull main in. Lmk if you need help. |
idk how this broke but i had claude fix it so hope it works
kinneyan
approved these changes
Mar 30, 2026
Owner
|
Don't forget to close out those tickets after merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Change backend endpoints to align with RESTful and project requirements.
Related Issue(s)
#57 #61 #66 #67
PR Type (Check all that apply)
Checklist
Make sure that the following steps are completed before requesting a review.
Additional Notes
Add any relevant information for reviewers here.